fix(design): address Phase 3 code review findings#11326
Closed
jd wants to merge 1 commit intodevs/jd/worktree-design/remove-chakra-color-block--ea7d94f7from
Closed
Conversation
This was referenced Apr 30, 2026
Member
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Apr 30, 2026
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for:
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for:
This rule is failing.
🔴 🔎 ReviewsWaiting for:
This rule is failing.
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
- Remove dead :not(.home-title) guard clauses in src/styles/index.css. The .home-title class was removed from the homepage MDX in Phase 3, so the guards now reference a class that no longer exists in the DOM. - Replace hard-coded hex colors in Search.scss search-highlight marks (#003dff in light, #5468ff in dark) with var(--theme-link). The token is already mode-aware so the dark override is redundant. Change-Id: Ie08c2f698b62a99b80d4ddcb33a635e632b9691d
jd
force-pushed
the
devs/jd/worktree-design/address-phase-3-code-review-findings--e08c2f69
branch
from
436de18 to
9dcee6d
Compare
This was referenced Apr 30, 2026
Member
Author
Revision history
|
jd
deleted the branch
devs/jd/worktree-design/remove-chakra-color-block--ea7d94f7
jd
deleted the
devs/jd/worktree-design/address-phase-3-code-review-findings--e08c2f69
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dead :not(.home-title) guard clauses in src/styles/index.css.
The .home-title class was removed from the homepage MDX in Phase 3,
so the guards now reference a class that no longer exists in the DOM.
Replace hard-coded hex colors in Search.scss search-highlight marks
(#003dff in light, #5468ff in dark) with var(--theme-link). The token
is already mode-aware so the dark override is redundant.
Depends-On: #11325